test [nfc]: Add shorter name "testBinding" for TestZulipBinding.instance #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this a lot in our tests, and its name is kind of uncomfortably long for that. Make it shorter. In particular if in a test one wants the test binding object for Flutter itself (the TestWidgetsFlutterBinding), that's spelled `tester.binding` (where `tester` is the argument passed to the `testWidgets` callback). So this makes our own test binding object be comparably accessible, as `testBinding`.
In particular make the name appropriately specific about what's being launched, since we're exporting it from this more general context.
|
LGTM, thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this a lot in our tests, and its name is kind of uncomfortably
long for that. Make it shorter.
In particular if in a test one wants the test binding object for
Flutter itself (the TestWidgetsFlutterBinding), that's spelled
tester.binding(wheretesteris the argument passed to thetestWidgetscallback). So this makes our own test binding objectbe comparably accessible, as
testBinding.These cleanups originated in my draft branch for notifications, #122 / #123. There's still significant work for me to do before that branch is ready, but these seem independently helpful as we write more tests that use the global store or Flutter plugins.